MISRA Discussion Forums

MISRA Discussion Forums > MISRA C > MISRA C:2012 and MISRA C:2023 guidelines > 8.14 Control statement expressions > Rule 14.3 and preprocessor constants
Full Version: Rule 14.3 and preprocessor constants
You're currently viewing a stripped down version of our content. View the full version with proper formatting.

hummelvario

01-10-2021, 09:31 AM
Hi,


I have a question regarding a reported MISRA violation in our code, which isn't completely clear to me after reading the MISRA Guidelines.

Does the MISRA C:2012 Rule 14.3 (Controlling expressions shall not be invariant) also apply to predefined constants, which include function-lika macros?

Example:

Code:
#define ROUND_TO(type, val) ((type) (((val) < 0.0) ? ((val) - 0.5) : ((val) + 0.5)))

#define RMS_TO_AVERAGE  ROUND_TO(uint16_t, ((70.0) / (1.11)))


In this case the expression ((val) < 0.0) is invariant, but it is only once used initialising a constant (RMS_TO_AVERAGE).


Regards, Kevin

misra-c

27-11-2021, 11:00 AM
As the rules stand, your example violates both rules 14.3 and 2.2.

The rules covering invariant controlling expressions (rule 14.3) and subsequent dead code (rule 2.2) in macro definitions are currently being reviewed by the MISRA C Working Group.
MISRA Discussion Forums > MISRA C > MISRA C:2012 and MISRA C:2023 guidelines > 8.14 Control statement expressions > Rule 14.3 and preprocessor constants