+- MISRA Discussion Forums (https://forum.misra.org.uk)
+-- Forum: MISRA C (https://forum.misra.org.uk/forumdisplay.php?fid=4)
+--- Forum: MISRA C:2012 and MISRA C:2023 guidelines (https://forum.misra.org.uk/forumdisplay.php?fid=21)
+---- Forum: 8.2 Unused code (https://forum.misra.org.uk/forumdisplay.php?fid=157)
+---- Thread: Rule 2.5 and unused macro parameter (/showthread.php?tid=1533)
Rule 2.5 and unused macro parameter - Mike Bailey - 12-03-2020
Rule 2.5 states "A project should not contain unused macro declaration".
Forum post https://www.misra.org.uk/forum/viewtopic.php?f=216&t=1571 acknowledges that Rule 2.5 should be "A project should not contain unused macro definition", however a change to "A project should not contain unused macro identifier" would cover both the original intent and also catch the following coding error without compromising rule decidability:
[code]
/* Macro containing coding error - macro parameter pin is unused */
#define SET_PIN(pin, polarity) \
((GPIO->PIN[pin_number] & ~PIN_Msk) | (polarity
Re: Rule 2.5 and unused macro parameter - misra-c - 29-04-2020
Thank you for your comment on rule 2.5. The MISRA-C working group will consider it for future versions.